Seen both sides of Egypt, working and holidaying.
Like all resorts, there's good aspects and bad.
I didnt get inside the pyramids at Giza (just a quick visit before flying) but it didnt impress me. Its nice to 'tick it off' but be prepared for some serious hassle from the guides and avoid the visit to the perfume museum. Its not a museum, its a shop the guides will try to take you to, its hard hard hard sell. You get swamped as before you even get in the complex. You need a steely attitude, everything costs the earth, horse and camel rides etc etc.
As Global says, its a dirty noisy insane city but i kinda enjoyed that. You get a headache just sitting in a taxi as a passenger. 5 lanes of cars trying to jostle for position in 3 lanes of road, it really is insane.
Sharm is ok, as The Dr says it has the best snorkelling ive ever ever seen. That was the highlight for me. Astounding.
The beaches at Sharm itself were'nt that good IMO, too busy, but we used a beach a few miles up the road. 1 mile of sandy beach bordered by coral and plenty of cafes and bars. much quieter, much nicer. I'd go back just for that, brilliant.
The Egyptians are hard sell merchants, you do get hassle but keep smiling, keep saying no and keep walking. Dont get invited to sign their visitors books, its just a ruse to get you in their shop, then the hard sell starts.
Steely attitude. Its the only way.
For all that, they're phenomenally friendly, working there i saw that much more when you're not a tourist.